[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vfwp_uvVW51FwwRWorDibJTu4zRpMhQ9iF3sTe1yrmsTw@mail.gmail.com>
Date: Mon, 30 Nov 2020 13:44:33 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Schrempf Frieder <frieder.schrempf@...tron.de>
Cc: Charles Gorand <charles.gorand@...innov.com>,
Clément Perrochaud
<clement.perrochaud@...innov.com>,
"David S. Miller" <davem@...emloft.net>,
devicetree <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-nfc@...ts.01.org, netdev <netdev@...r.kernel.org>,
Stephan Gerhold <stephan@...hold.net>
Subject: Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional
On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder
<frieder.schrempf@...tron.de> wrote:
>
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>
> There are other NXP NCI compatible NFC controllers such as the PN7150
> that use an integrated firmware and therefore do not have a GPIO to
> select firmware downloading mode. To support these kind of chips,
> let's make the firmware GPIO optional.
...
> - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
> + if (phy->gpiod_fw)
> + gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
This change is not needed.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists