linux-kernel - Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 12:49:17 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Charles Gorand <charles.gorand@...innov.com>,
        Clément Perrochaud 
        <clement.perrochaud@...innov.com>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-nfc@...ts.01.org, netdev <netdev@...r.kernel.org>,
        Stephan Gerhold <stephan@...hold.net>
Subject: Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional

On 30.11.20 12:44, Andy Shevchenko wrote:
> On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder
> <frieder.schrempf@...tron.de> wrote:
>>
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> There are other NXP NCI compatible NFC controllers such as the PN7150
>> that use an integrated firmware and therefore do not have a GPIO to
>> select firmware downloading mode. To support these kind of chips,
>> let's make the firmware GPIO optional.
> 
> ...
> 
>> -       gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
>> +       if (phy->gpiod_fw)
>> +               gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
> 
> This change is not needed.

Indeed, thanks!