linux-kernel - Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X8TzY0rotaSZ2FYv@jagdpanzerIV.localdomain>
Date:   Mon, 30 Nov 2020 22:28:03 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Christoph Hellwig <hch@....de>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Namjae Jeon <linkinjeon@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on
 non-posix-acl build

Hi,

On (20/11/30 14:09), Andreas Gruenbacher wrote:
> 
> Sergey, what actual problem is your patch trying to solve? It sounds
> like this is either theoretical and pointless, or you're trying to
> build an external module that uses POSIX ACL functions that shouldn't
> be needed when CONFIG_FS_POSIX_ACL is disabled.

It's an external module, that OpenWRT folks build with !FS_POSIX_ACL.
It compiles just fine, but modprobe fails because there are several
exported ACL symbols that don't provide dummy definitions (which the
module in question didn't guard with ifdef-s).

> In the latter case, the external module will just end up including dead
> code, so the module should be fixed instead.

ifdef-s work. But since posix_acl.h already provides some dummy
definitions for exported symbols, I thought that that list can
be extended (become complete).

	-ss