linux-kernel - Re: [PATCH] perf record: Synthesize cgroup events only if needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7chmmB9=2-npHr8WnyA6jHqxQ+rf3jix+cHoa2C+3C9YJQ@mail.gmail.com>
Date:   Mon, 30 Nov 2020 22:27:59 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH] perf record: Synthesize cgroup events only if needed

Hi Arnaldo,

On Sat, Nov 28, 2020 at 2:30 AM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> Em Fri, Nov 27, 2020 at 04:45:57PM +0100, Jiri Olsa escreveu:
> > On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote:
> > > It didn't check the tool->cgroup_events bit which is set when
> > > the --all-cgroups option is given.  Without it, samples will not have
> > > cgroup info so no reason to synthesize.
> > >
> > > We can check the PERF_RECORD_CGROUP records after running perf record
> > > *WITHOUT* the --all-cgroups option:
> > >
> > > Before:
> > >   $ perf report -D | grep CGROUP
> > >   0 0 0x8430 [0x38]: PERF_RECORD_CGROUP cgroup: 1 /
> > >           CGROUP events:          1
> > >           CGROUP events:          0
> > >           CGROUP events:          0
> > >
> > > After:
> > >   $ perf report -D | grep CGROUP
> > >           CGROUP events:          0
> > >           CGROUP events:          0
> > >           CGROUP events:          0
> > >
> > > Fixes: 8fb4b67939e16 ("perf record: Add --all-cgroups option")
> > > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > > ---
> > >  tools/perf/util/synthetic-events.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> > > index 8a23391558cf..d9c624377da7 100644
> > > --- a/tools/perf/util/synthetic-events.c
> > > +++ b/tools/perf/util/synthetic-events.c
> > > @@ -563,6 +563,9 @@ int perf_event__synthesize_cgroups(struct perf_tool *tool,
> > >     char cgrp_root[PATH_MAX];
> > >     size_t mount_len;  /* length of mount point in the path */
> > >
> > > +   if (!tool || !tool->cgroup_events)
> > > +           return 0;
> >
> > can !tool actually happen here? or it's just being extra cautious
> >
> > Acked-by: Jiri Olsa <jolsa@...hat.com>
>
> Thanks, tested with/without --all-cgroups and applied.

Thanks for doing that!

Namhyung