[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFr9PXnkxBeujWFqVWfonEKEJ81ExnYcjr3jRMTBobGf9q2jsA@mail.gmail.com>
Date: Mon, 30 Nov 2020 23:11:58 +0900
From: Daniel Palmer <daniel@...f.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: DTML <devicetree@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
Willy Tarreau <w@....eu>
Subject: Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi
Hi Arnd,
On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann <arnd@...nel.org> wrote:
>
> On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer <daniel@...f.com> wrote:
> >
> > +&riu {
> > + smpctrl@...000 {
> > + compatible = "mstar,smpctrl";
> > + reg = <0x204000 0x200>;
> > + status = "okay";
> > + };
>
> You probably want some more specific compatible value, in case there are
> multiple SoCs from mstar that have an smpctrl block and they don't all use
> an exactly identical register layout.
>
>From what I can tell these are in the same place for the infinity2m and
the other SMP chip in this series that are in the infinity6 series.
Would "mstar,i2m-smpctrl" make more sense?
Thanks,
Daniel
Powered by blists - more mailing lists