linux-kernel - Re: [PATCH 9/9] ARM: mstar: SMP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFr9PXksWa_u9TSz6FpTvB0fFMQvpTua7EVKKnfUutmZVtWq6A@mail.gmail.com>
Date:   Mon, 30 Nov 2020 23:25:34 +0900
From:   Daniel Palmer <daniel@...f.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     DTML <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
        Willy Tarreau <w@....eu>
Subject: Re: [PATCH 9/9] ARM: mstar: SMP support

Hi Arnd,

On Mon, 30 Nov 2020 at 22:42, Arnd Bergmann <arnd@...nel.org> wrote:
> > +struct smp_operations __initdata mstarv7_smp_ops  = {
> > +       .smp_boot_secondary = mstarv7_boot_secondary,
> > +};
> > +#endif
>
> So no hotplug operations?

Not yet. There are controls to power down different bits of the chip,
assert internal resets and so on so it might be possible to add that
later but I haven't worked out where those bits are yet for the second
cpu.

> Or better, use CPU_METHOD_OF_DECLARE() instead of smp_ops.

I'll do that for the v2.

Was there anything else that looked fishy? Every other platform seems
to have a lot of code for moving secondary CPUs from the boot ROM into
somewhere the kernel can control the order in which they come online
(vendor code has a copy/paste of the vexpress code) so I was worried I
missed something.

Thanks,

Daniel