linux-kernel - Re: [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and remove remove()

Open Source and information security mailing list archives

Message-ID: <20201130161600.00000d66@Huawei.com>
Date:   Mon, 30 Nov 2020 16:16:00 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Michal Simek <michal.simek@...inx.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        "Bartosz Golaszewski" <bgolaszewski@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and
 remove remove()

On Mon, 30 Nov 2020 15:30:22 +0100
Bartosz Golaszewski <brgl@...ev.pl> wrote:

> On Mon, Nov 30, 2020 at 3:28 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > In order to simplify resource management and error paths in probe() and
> > entirely drop the remove() callback - use devres helpers wherever
> > possible. Define devm actions for cancelling the delayed work and
> > disabling the clock.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > ---  
> 
> [snip]
> 
> >
> >         /* Set thresholds to min/max */
> >         for (i = 0; i < 16; i++) {
> > @@ -1334,59 +1353,23 @@ static int xadc_probe(struct platform_device *pdev)
> >                 ret = xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(i),
> >                         xadc->threshold[i]);
> >                 if (ret)
> > -                       goto err_free_irq;
> > +                       return ret;
> >         }
> >
> >         /* Go to non-buffered mode */
> >         xadc_postdisable(indio_dev);
> >
> > -       ret = iio_device_register(indio_dev);
> > +       ret = devm_iio_device_register(dev, indio_dev);
> >         if (ret)
> > -               goto err_free_irq;
> > +               return ret;
> >
> >         platform_set_drvdata(pdev, indio_dev);
> >  
> 
> Cr*p I was supposed to drop this line...
> 
> Jonathan: can you drop it when applying?
Sure. 

J

> 
> Bartosz
> 
> [snip]
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives