lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 30 Nov 2020 20:21:10 +0000
From:   Jonathan Cameron <>
To:     Bartosz Golaszewski <>
Cc:     Lars-Peter Clausen <>,
        Peter Meerwald-Stadler <>,
        Michal Simek <>,,,,
        Bartosz Golaszewski <>,
        Anand Ashok Dumbre <>
Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres

On Mon, 30 Nov 2020 15:27:56 +0100
Bartosz Golaszewski <> wrote:

> From: Bartosz Golaszewski <>
> This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use
> devm_krealloc()"). I noticed we can use even more devres helpers and entirely
> drop the remove() callback.
> v1 -> v2:
> - squash three patches adding more devres calls into one for easier review
> - don't insist on the 80 characters limit
> - add a new helper: devm_krealloc_array() and use it
> v2 -> v3:
> - drop the devm_krealloc_array() helper
> Bartosz Golaszewski (3):
>   iio: adc: xilinx: use helper variable for &pdev->dev
>   iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc()
>   iio: adc: xilinx: use more devres helpers and remove remove()
>  drivers/iio/adc/xilinx-xadc-core.c | 157 ++++++++++++++---------------
>  1 file changed, 74 insertions(+), 83 deletions(-)

Series looks good to me but would like to leave it a little longer to let
others take a look at it. That will probably mean it falls into next cycle

+CC Anand who is looking at another series touching this driver and might
give this one a spin as well.



Powered by blists - more mailing lists