linux-kernel - RE: [PATH v3 0/3] iio: adc: xilinx: use even more devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR02MB6916FD4844C5471C635DAD1AA9CA0@BY5PR02MB6916.namprd02.prod.outlook.com>
Date:   Fri, 11 Dec 2020 12:15:15 +0000
From:   Anand Ashok Dumbre <ANANDASH@...inx.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
CC:     Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Michal Simek <michals@...inx.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: RE: [PATH v3 0/3] iio: adc: xilinx: use even more devres

> -----Original Message-----
> From: Jonathan Cameron <jic23@...nel.org>
> Sent: Monday 30 November 2020 8:21 PM
> To: Bartosz Golaszewski <brgl@...ev.pl>
> Cc: Lars-Peter Clausen <lars@...afoo.de>; Peter Meerwald-Stadler
> <pmeerw@...erw.net>; Michal Simek <michals@...inx.com>; linux-
> iio@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Bartosz Golaszewski
> <bgolaszewski@...libre.com>; Anand Ashok Dumbre
> <ANANDASH@...inx.com>
> Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres
> 
> On Mon, 30 Nov 2020 15:27:56 +0100
> Bartosz Golaszewski <brgl@...ev.pl> wrote:
> 
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc:
> > use devm_krealloc()"). I noticed we can use even more devres helpers
> > and entirely drop the remove() callback.
> >
> > v1 -> v2:
> > - squash three patches adding more devres calls into one for easier
> > review
> > - don't insist on the 80 characters limit
> > - add a new helper: devm_krealloc_array() and use it
> >
> > v2 -> v3:
> > - drop the devm_krealloc_array() helper
> >
> > Bartosz Golaszewski (3):
> >   iio: adc: xilinx: use helper variable for &pdev->dev
> >   iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc()
> >   iio: adc: xilinx: use more devres helpers and remove remove()
> >
> >  drivers/iio/adc/xilinx-xadc-core.c | 157
> > ++++++++++++++---------------
> >  1 file changed, 74 insertions(+), 83 deletions(-)
> >
> 
> Series looks good to me but would like to leave it a little longer to let others
> take a look at it. That will probably mean it falls into next cycle now.
> 
> +CC Anand who is looking at another series touching this driver and
> +might
> give this one a spin as well.
> 
> Thanks,
> 
> Jonathan

Hi Jonathan, Bartosz,

I have tested and reviewed the patch and everything looks good.
I have another patch series on the same files that might cause conflicts.

Reviewed-by: Anand Ashok Dumbre <anandash@...inx.com>
Tested-by: Anand Ashok Dumbre <anandash@...inx.com>

Thanks,
Anand