linux-kernel - Re: [PATCH] gpio: xra1403: remove unneeded spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd=S26VgrkcQoMN=xFburOn8207MUYbGzMBLHgn0iuErA@mail.gmail.com>
Date:   Mon, 30 Nov 2020 19:16:59 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nandor Han <nandor.han@...com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()

On Mon, Nov 30, 2020 at 6:37 PM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean
> > <alexandru.ardelean@...log.com> wrote:
> > >
> > > There is no matching spi_get_drvdata() call in the driver, so there is no
> > > need to do spi_set_drvdata(). This looks like it probably was copied from a
> > > driver that used both spi_set_drvdata() & spi_get_drvdata().
> >
> > While above luckily (*) okay it may not always be the case.
> >
> > *) it can be paired with dev_get_drvdata() which is usual for PM callbacks.
> >
> > With amended commit message
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> >
>
> I applied this patch. I wasn't sure exactly how you want the commit
> message to be changed - it sounds pretty clear to me so I took it.

For example, by adding " or dev_get_drvdata()" to the end.

-- 
With Best Regards,
Andy Shevchenko