linux-kernel - Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201130171748.GC10078@infradead.org>
Date:   Mon, 30 Nov 2020 17:17:48 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Daniel Wagner <dwagner@...e.de>
Cc:     linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org, Ming Lei <ming.lei@...hat.com>
Subject: Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

On Mon, Nov 30, 2020 at 11:19:21AM +0100, Daniel Wagner wrote:
> It's guaranteed that no request is in flight when a hctx is going
> offline. This warning is only triggered when the wq's CPU is hot
> plugged and the blk-mq is not synced up yet.
> 
> As this state is temporary and the request is still processed
> correctly, better remove the warning as this is the fast path.
> 
> Suggested-by: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: Daniel Wagner <dwagner@...e.de>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>