linux-kernel - Re: [PATCH v4 1/5] genirq/affinity: Add irq_update_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22315d74-0696-85ef-882c-85961cfb4f32@huawei.com>
Date:   Tue, 1 Dec 2020 15:22:38 +0000
From:   John Garry <john.garry@...wei.com>
To:     Thomas Gleixner <tglx@...utronix.de>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <lenb@...nel.org>,
        <rjw@...ysocki.net>, <gregkh@...uxfoundation.org>, <maz@...nel.org>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <linux-acpi@...r.kernel.org>,
        <dwagner@...e.de>
Subject: Re: [PATCH v4 1/5] genirq/affinity: Add irq_update_affinity_desc()

Hi Thomas,

I'll go with something extra like:

> 
>> Add a function to allow the affinity of an interrupt be switched to
>> managed, such that interrupts allocated for platform devices may be
>> managed.
> 
> Could you please add a paragraph which explains the limitations of that
> interface?

This new interface has certain limitations, and attempts to use it in 
the following circumstances will fail:
- For when the kernel is configured for generic IRQ reservation mode (in 
config GENERIC_IRQ_RESERVATION_MODE). The reason being that it could 
conflict with managed vs. non-managed interrupt accounting there.
- The interrupt is already started, which should not be the case during init
- The interrupt is already configured as managed, which means double init

> 
>> +/**
>> + * irq_update_affinity_desc - Update affinity management for an interrupt
>> + * @irq:	The interrupt number to update
>> + * @affinity:	Pointer to the affinity descriptor
>> + *
>> + * This interface can be used to configure the affinity management of
>> + * interrupts which have been allocated already.
> 

/*
  * There are certain limitations on when it may be used - attempts to 
use it for when the kernel is configured for generic IRQ reservation 
mode (in config GENERIC_IRQ_RESERVATION_MODE) will fail, as it may 
conflict with managed/non-managed interrupt accounting. In addition, 
attempts to use it on an interrupt which is already started or which has 
already been configured as managed will also fail, as these mean invalid 
init state or double init.

...

Let me know if not good, if not I'll post again soon.

Thanks,
John