linux-kernel - Re: [PATCH 09/22] misc: xlink-pcie: lh: Add core communication logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8YX1q3ExjhBGd3+@kroah.com>
Date:   Tue, 1 Dec 2020 11:15:50 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     mgross@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, markgross@...nel.org,
        adam.r.gretzinger@...el.com,
        Srikanth Thokala <srikanth.thokala@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 09/22] misc: xlink-pcie: lh: Add core communication logic

On Mon, Nov 30, 2020 at 03:06:54PM -0800, mgross@...ux.intel.com wrote:
> +static int rx_pool_size = SZ_32M;
> +module_param(rx_pool_size, int, 0664);
> +MODULE_PARM_DESC(rx_pool_size, "receiving pool size (default 32 MiB)");
> +
> +static int tx_pool_size = SZ_32M;
> +module_param(tx_pool_size, int, 0664);
> +MODULE_PARM_DESC(tx_pool_size, "transmitting pool size (default 32 MiB)");
> +
> +static int fragment_size = XPCIE_FRAGMENT_SIZE;
> +module_param(fragment_size, int, 0664);
> +MODULE_PARM_DESC(fragment_size, "transfer descriptor size (default 128 KiB)");
> +
> +static bool tx_pool_coherent = true;
> +module_param(tx_pool_coherent, bool, 0664);
> +MODULE_PARM_DESC(tx_pool_coherent,
> +		 "transmitting pool using coherent memory (default true)");
> +
> +static bool rx_pool_coherent;
> +module_param(rx_pool_coherent, bool, 0664);
> +MODULE_PARM_DESC(rx_pool_coherent,
> +		 "receiving pool using coherent memory (default false)");

This is not the 1990's anymore, please never use module parameters for
new drivers as they do not work well (i.e. they do not work at all on a
individual device basis.)

Make this all "just work" so that userspace does not have to "tune"
anything.  But if you really must allow configuration like this, then
use configfs, as that's what it is there for.

thanks,

greg k-h