linux-kernel - Re: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8YYPxK9gnTvubTJ@kroah.com>
Date:   Tue, 1 Dec 2020 11:17:35 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     mgross@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, markgross@...nel.org,
        adam.r.gretzinger@...el.com,
        Srikanth Thokala <srikanth.thokala@...el.com>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for
 Local Host

On Mon, Nov 30, 2020 at 03:06:52PM -0800, mgross@...ux.intel.com wrote:
> +#define XPCIE_VERSION_MAJOR 0
> +#define XPCIE_VERSION_MINOR 5
> +#define XPCIE_VERSION_BUILD 0
> +#define _TOSTR(X) #X
> +#define _VERSION(A, B, C) _TOSTR(A) "." _TOSTR(B) "." _TOSTR(C)
> +#define XPCIE_DRIVER_VERSION \
> +	_VERSION(XPCIE_VERSION_MAJOR, XPCIE_VERSION_MINOR, XPCIE_VERSION_BUILD)
> +
> +struct xpcie_version {
> +	u8 major;
> +	u8 minor;
> +	u16 build;
> +} __packed;

Now that the driver will be in the tree, there is no need for this
structure or these fields, right?  It will just be the version of the
kernel.  Otherwise something like this will never be correct, given
stable kernel releases and enterprise kernel releases, and loads of
other messy backported trees.  Just stick to the kernel release number
please, that's the only sane thing.

thanks,

greg k-h