[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <DM6PR11MB3642703026686BCA8200BE2F97F20@DM6PR11MB3642.namprd11.prod.outlook.com>
Date: Thu, 3 Dec 2020 15:57:19 +0000
From: "Lu, Brent" <brent.lu@...el.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC: Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@...el.com>,
"R, Dharageswari" <dharageswari.r@...el.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Takashi Iwai <tiwai@...e.com>,
Jie Yang <yang.jie@...ux.intel.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
Ben Zhang <benzh@...omium.org>,
Mark Brown <broonie@...nel.org>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@...el.com>,
Fred Oh <fred.oh@...ux.intel.com>,
"M, Naveen" <naveen.m@...el.com>,
Libin Yang <libin.yang@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Rander Wang <rander.wang@...ux.intel.com>,
"Zhi, Yong" <yong.zhi@...el.com>
Subject: RE: [PATCH] ASoC: intel: sof_rt5682: Add support for
tgl_rt1011_rt5682
> > +struct {
> > + unsigned int tx;
> > + unsigned int rx;
> > +} rt1011_tdm_mask[] = {
> > + {.tx = 0x4, .rx = 0x1},
> > + {.tx = 0x8, .rx = 0x2},
> > +};
>
> as noted in the GitHub review this should be static and possibly const.
Will fix in v2. Also add const to structures in soc-acpi-intel-tgl-match.c
and include file in sof_realtek_common.c
Regards,
Brent
Powered by blists - more mailing lists