linux-kernel - Re: [PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201202171925.74e546f4@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Wed, 2 Dec 2020 17:19:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, jonathanh@...dia.com, evgreen@...omium.org,
        cpratapa@...eaurora.org, bjorn.andersson@...aro.org,
        subashab@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: ipa: fix build-time bug in
 ipa_hardware_config_qsb()

On Wed,  2 Dec 2020 08:15:02 -0600 Alex Elder wrote:
> Jon Hunter reported observing a build bug in the IPA driver:
>   https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef8260e2@nvidia.com
> 
> The problem is that the QMB0 max read value set for IPA v4.5 (16) is
> too large to fit in the 4-bit field.
> 
> The actual value we want is 0, which requests that the hardware use
> the maximum it is capable of.
> 
> Reported-by: Jon Hunter <jonathanh@...dia.com>
> Tested-by: Jon Hunter <jonathanh@...dia.com>
> Signed-off-by: Alex Elder <elder@...aro.org>

Applied, thanks!