linux-kernel - Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 14:25:15 +0100
From:   Greg KH <greg@...ah.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        toddpoynor@...gle.com, sbranden@...adcom.com, rjui@...adcom.com,
        speakup@...ux-speakup.org, rcy@...gle.com, f.fainelli@...il.com,
        rspringer@...gle.com, laurent.pinchart@...asonboard.com,
        netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        mchehab@...nel.org, nsaenzjulienne@...e.de,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded
 MODULE_VERSION() call

On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
> 
> The drivers have received lots of changes, without the module version
> (or the underlying DRV_VERSION macro) ever changed, since the code
> landed in the kernel tree. So, it doesn't seem to have any practical
> meaning anymore.
> 
> Signed-off-by: Enrico Weigelt <info@...ux.net>
> ---
>  drivers/accessibility/speakup/main.c           | 1 -

<snip>

Yous subject line is odd, these are not "staging" drivers anymore, so
why do you say they are there?

thanks,

greg k-h