linux-kernel - Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201203135640.GS2767@kadam>
Date:   Thu, 3 Dec 2020 16:56:40 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Greg KH <greg@...ah.com>
Cc:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        devel@...verdev.osuosl.org, f.fainelli@...il.com,
        sbranden@...adcom.com, rjui@...adcom.com, mchehab@...nel.org,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org,
        rcy@...gle.com, rspringer@...gle.com,
        laurent.pinchart@...asonboard.com, netdev@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, toddpoynor@...gle.com,
        nsaenzjulienne@...e.de, linux-media@...r.kernel.org
Subject: Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded
 MODULE_VERSION() call

On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> > 
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> > 
> > Signed-off-by: Enrico Weigelt <info@...ux.net>
> > ---
> >  drivers/accessibility/speakup/main.c           | 1 -
> 
> <snip>
> 
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?

Also putting "drivers:" in the subject always seems superfluous.

regards,
dan carpenter