| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a6cd4183b9bf4e72b649a271b4843f89@hisilicon.com>
Date: Fri, 4 Dec 2020 00:01:41 +0000
From: "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>
To: Muchun Song <songmuchun@...edance.com>,
"corbet@....net" <corbet@....net>,
"mike.kravetz@...cle.com" <mike.kravetz@...cle.com>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"bp@...en8.de" <bp@...en8.de>, "x86@...nel.org" <x86@...nel.org>,
"hpa@...or.com" <hpa@...or.com>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"luto@...nel.org" <luto@...nel.org>,
"peterz@...radead.org" <peterz@...radead.org>,
"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"paulmck@...nel.org" <paulmck@...nel.org>,
"mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
"pawan.kumar.gupta@...ux.intel.com"
<pawan.kumar.gupta@...ux.intel.com>,
"rdunlap@...radead.org" <rdunlap@...radead.org>,
"oneukum@...e.com" <oneukum@...e.com>,
"anshuman.khandual@....com" <anshuman.khandual@....com>,
"jroedel@...e.de" <jroedel@...e.de>,
"almasrymina@...gle.com" <almasrymina@...gle.com>,
"rientjes@...gle.com" <rientjes@...gle.com>,
"willy@...radead.org" <willy@...radead.org>,
"osalvador@...e.de" <osalvador@...e.de>,
"mhocko@...e.com" <mhocko@...e.com>
CC: "duanxiongchun@...edance.com" <duanxiongchun@...edance.com>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v7 13/15] mm/hugetlb: Add a kernel parameter
hugetlb_free_vmemmap
> -----Original Message-----
> From: Muchun Song [mailto:songmuchun@...edance.com]
> Sent: Tuesday, December 1, 2020 4:19 AM
> To: corbet@....net; mike.kravetz@...cle.com; tglx@...utronix.de;
> mingo@...hat.com; bp@...en8.de; x86@...nel.org; hpa@...or.com;
> dave.hansen@...ux.intel.com; luto@...nel.org; peterz@...radead.org;
> viro@...iv.linux.org.uk; akpm@...ux-foundation.org; paulmck@...nel.org;
> mchehab+huawei@...nel.org; pawan.kumar.gupta@...ux.intel.com;
> rdunlap@...radead.org; oneukum@...e.com; anshuman.khandual@....com;
> jroedel@...e.de; almasrymina@...gle.com; rientjes@...gle.com;
> willy@...radead.org; osalvador@...e.de; mhocko@...e.com; Song Bao Hua (Barry
> Song) <song.bao.hua@...ilicon.com>
> Cc: duanxiongchun@...edance.com; linux-doc@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-mm@...ck.org;
> linux-fsdevel@...r.kernel.org; Muchun Song <songmuchun@...edance.com>
> Subject: [PATCH v7 13/15] mm/hugetlb: Add a kernel parameter
> hugetlb_free_vmemmap
>
> Add a kernel parameter hugetlb_free_vmemmap to disable the feature of
> freeing unused vmemmap pages associated with each hugetlb page on boot.
>
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
Reviewed-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 9 +++++++++
> Documentation/admin-guide/mm/hugetlbpage.rst | 3 +++
> arch/x86/mm/init_64.c | 5 +++--
> include/linux/hugetlb.h | 19 +++++++++++++++++++
> mm/hugetlb_vmemmap.c | 18 +++++++++++++++++-
> 5 files changed, 51 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt
> b/Documentation/admin-guide/kernel-parameters.txt
> index 3ae25630a223..9e6854f21d55 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1551,6 +1551,15 @@
> Documentation/admin-guide/mm/hugetlbpage.rst.
> Format: size[KMG]
>
> + hugetlb_free_vmemmap=
> + [KNL] When CONFIG_HUGETLB_PAGE_FREE_VMEMMAP is set,
> + this controls freeing unused vmemmap pages associated
> + with each HugeTLB page.
> + Format: { on | off (default) }
> +
> + on: enable the feature
> + off: disable the feature
> +
> hung_task_panic=
> [KNL] Should the hung task detector generate panics.
> Format: 0 | 1
> diff --git a/Documentation/admin-guide/mm/hugetlbpage.rst
> b/Documentation/admin-guide/mm/hugetlbpage.rst
> index f7b1c7462991..6a8b57f6d3b7 100644
> --- a/Documentation/admin-guide/mm/hugetlbpage.rst
> +++ b/Documentation/admin-guide/mm/hugetlbpage.rst
> @@ -145,6 +145,9 @@ default_hugepagesz
>
> will all result in 256 2M huge pages being allocated. Valid default
> huge page size is architecture dependent.
> +hugetlb_free_vmemmap
> + When CONFIG_HUGETLB_PAGE_FREE_VMEMMAP is set, this enables freeing
> + unused vmemmap pages associated each HugeTLB page.
>
> When multiple huge page sizes are supported, ``/proc/sys/vm/nr_hugepages``
> indicates the current number of pre-allocated huge pages of the default size.
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 155cb06a6961..fcdc020904a8 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -34,6 +34,7 @@
> #include <linux/gfp.h>
> #include <linux/kcore.h>
> #include <linux/bootmem_info.h>
> +#include <linux/hugetlb.h>
>
> #include <asm/processor.h>
> #include <asm/bios_ebda.h>
> @@ -1557,7 +1558,7 @@ int __meminit vmemmap_populate(unsigned long start,
> unsigned long end, int node,
> {
> int err;
>
> - if (IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP))
> + if (is_hugetlb_free_vmemmap_enabled())
> err = vmemmap_populate_basepages(start, end, node, NULL);
> else if (end - start < PAGES_PER_SECTION * sizeof(struct page))
> err = vmemmap_populate_basepages(start, end, node, NULL);
> @@ -1613,7 +1614,7 @@ void register_page_bootmem_memmap(unsigned long
> section_nr,
> get_page_bootmem(section_nr, pud_page(*pud), MIX_SECTION_INFO);
>
> if (!boot_cpu_has(X86_FEATURE_PSE) ||
> - IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP)) {
> + is_hugetlb_free_vmemmap_enabled()) {
> next = (addr + PAGE_SIZE) & PAGE_MASK;
> pmd = pmd_offset(pud, addr);
> if (pmd_none(*pmd))
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 4efeccb7192c..66d82ae7b712 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -773,6 +773,20 @@ static inline void huge_ptep_modify_prot_commit(struct
> vm_area_struct *vma,
> }
> #endif
>
> +#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
> +extern bool hugetlb_free_vmemmap_enabled;
> +
> +static inline bool is_hugetlb_free_vmemmap_enabled(void)
> +{
> + return hugetlb_free_vmemmap_enabled;
> +}
> +#else
> +static inline bool is_hugetlb_free_vmemmap_enabled(void)
> +{
> + return false;
> +}
> +#endif
> +
> #else /* CONFIG_HUGETLB_PAGE */
> struct hstate {};
>
> @@ -926,6 +940,11 @@ static inline void set_huge_swap_pte_at(struct mm_struct
> *mm, unsigned long addr
> pte_t *ptep, pte_t pte, unsigned long sz)
> {
> }
> +
> +static inline bool is_hugetlb_free_vmemmap_enabled(void)
> +{
> + return false;
> +}
> #endif /* CONFIG_HUGETLB_PAGE */
>
> static inline spinlock_t *huge_pte_lock(struct hstate *h,
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index a3714db7f400..ebc710d148e4 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -131,6 +131,21 @@ typedef void (*vmemmap_remap_pte_func_t)(struct page
> *reuse, pte_t *pte,
> unsigned long start, unsigned long end,
> void *priv);
>
> +bool hugetlb_free_vmemmap_enabled;
> +
> +static int __init early_hugetlb_free_vmemmap_param(char *buf)
> +{
> + if (!buf)
> + return -EINVAL;
> +
> + if (!strcmp(buf, "on"))
> + hugetlb_free_vmemmap_enabled = true;
> + else if (strcmp(buf, "off"))
> + return -EINVAL;
> +
> + return 0;
> +}
> +early_param("hugetlb_free_vmemmap", early_hugetlb_free_vmemmap_param);
>
> static inline unsigned int vmemmap_pages_per_hpage(struct hstate *h)
> {
> @@ -325,7 +340,8 @@ void __init hugetlb_vmemmap_init(struct hstate *h)
> unsigned int nr_pages = pages_per_huge_page(h);
> unsigned int vmemmap_pages;
>
> - if (!is_power_of_2(sizeof(struct page))) {
> + if (!is_power_of_2(sizeof(struct page)) ||
> + !hugetlb_free_vmemmap_enabled) {
> pr_info("disable freeing vmemmap pages for %s\n", h->name);
> return;
> }
> --
> 2.11.0
Thanks
Barry
Powered by blists - more mailing lists