linux-kernel - Re: [PATCH] phy: mediatek: allow compile-testing the hdmi phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3tbXLD-0UBCkYX+s1AR=edbT085AcMmU8iPO1o-TMF=Q@mail.gmail.com>
Date:   Fri, 4 Dec 2020 14:53:33 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        CK Hu <ck.hu@...iatek.com>, Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC..." 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: mediatek: allow compile-testing the hdmi phy

On Fri, Dec 4, 2020 at 2:47 AM Chunfeng Yun <chunfeng.yun@...iatek.com> wrote:

> > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> > index 65ed26e40c9f..29a85b2738f8 100644
> > --- a/drivers/phy/mediatek/Kconfig
> > +++ b/drivers/phy/mediatek/Kconfig
> > @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY
> >
> >  config PHY_MTK_HDMI
> >       tristate "MediaTek HDMI-PHY Driver"
> > -     depends on ARCH_MEDIATEK && OF
> > +     depends on ARCH_MEDIATEK || COMPILE_TEST
> > +     depends on COMMON_CLK
> Seems no need add COMMON_CLK here

My mistake, I had squashed two build fixes for the same driver but
forgot to update the changelog with the other output. This is what
happens without CONFIG_COMMON_CLK:

arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function
`mtk_hdmi_phy_probe':
phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined
reference to `devm_clk_register'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined
reference to `of_clk_add_provider'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined
reference to `of_clk_src_simple_get'

I'll resend with that added in.

       Arnd