linux-kernel - Re: [PATCH v2 3/5] ARM: dts: meson: fix PHY deassert timing requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCA_eaJHv7e+8ZM=z=zUZ9uQY_JZ=618=LwJYM-Gi+OO+g@mail.gmail.com>
Date:   Sat, 5 Dec 2020 14:04:13 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     khilman@...libre.com, robh+dt@...nel.org,
        Neil Armstrong <narmstrong@...libre.com>, jbrunet@...libre.com,
        christianshewitt@...il.com, jian.hu@...ogic.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] ARM: dts: meson: fix PHY deassert timing requirements

Hi Stefan,

On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@...er.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. On similar boards with the same PHY this fixes an issue where
there's a typo here: it should be "registers"
this is the same for the other four patches also

> Ethernet link would not come up when using ip link set down/up.
I have never experienced that myself but gotten a few reports about this.
thank you very much for coming up with info from the datasheet!

the following stmmac patch [0] has been added recently which may - or
may not - have any impact also.

> Fixes: a2c6e82e5341 ("ARM: dts: meson: switch to the generic Ethernet PHY reset bindings")
> Signed-off-by: Stefan Agner <stefan@...er.ch>
with above typo fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
and also:
Tested-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> #
on Odroid-C1+


Best regards,
Martin


[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/stmicro/stmmac?id=56311a315da7ebc668dbcc2f1c99689cc10796c4