linux-kernel - Re: [PATCH v2 2/5] arm64: dts: meson: fix PHY deassert timing requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCAMFZDRBekFW_+BRaCgAX7ofyFR0Vu74Kj16h4=KR78XA@mail.gmail.com>
Date:   Sat, 5 Dec 2020 14:14:29 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     khilman@...libre.com, robh+dt@...nel.org,
        Neil Armstrong <narmstrong@...libre.com>, jbrunet@...libre.com,
        christianshewitt@...il.com, jian.hu@...ogic.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] arm64: dts: meson: fix PHY deassert timing requirements

On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@...er.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. This fixes an issue seen on ODROID-C2 where the Ethernet
> link doesn't come up when using ip link set down/up:
>   [ 6630.714855] meson8b-dwmac c9410000.ethernet eth0: Link is Down
>   [ 6630.785775] meson8b-dwmac c9410000.ethernet eth0: PHY [stmmac-0:00] driver [RTL8211F Gigabit Ethernet] (irq=36)
>   [ 6630.893071] meson8b-dwmac c9410000.ethernet: Failed to reset the dma
>   [ 6630.893800] meson8b-dwmac c9410000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
>   [ 6630.902835] meson8b-dwmac c9410000.ethernet eth0: stmmac_open: Hw setup failed
>
> Fixes: f29cabf240ed ("arm64: dts: meson: use the generic Ethernet PHY reset GPIO bindings")
> Signed-off-by: Stefan Agner <stefan@...er.ch>
with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>