lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <X80AySpyP3fxhRmb@kroah.com>
Date:   Sun, 6 Dec 2020 17:03:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     shaojie.dong@...c.iscas.ac.cn
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: check register_netdev() return value

On Sun, Dec 06, 2020 at 11:59:07PM +0800, shaojie.dong@...c.iscas.ac.cn wrote:
> From: "shaojie.dong" <shaojie.dong@...c.iscas.ac.cn>
> 
> Function register_netdev() can fail, so we should check it's return value

You just check it, you are not doing anything with it, which is just the
same as not checking this.

Please fix this properly.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ