linux-kernel - Re: [PATCH] staging: rtl8712: check register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202012070128.vfUqQOGG-lkp@intel.com>
Date:   Mon, 7 Dec 2020 01:10:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     shaojie.dong@...c.iscas.ac.cn, Larry.Finger@...inger.net,
        florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org
Cc:     kbuild-all@...ts.01.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, shaojie.dong@...c.iscas.ac.cn
Subject: Re: [PATCH] staging: rtl8712: check register_netdev() return value

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/shaojie-dong-isrc-iscas-ac-cn/staging-rtl8712-check-register_netdev-return-value/20201207-000540
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 138f3e1265488a9163be7f379073297ba8545cca
config: arc-allmodconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a5d44fc70b0f1b3d0a23e3c3bab16a04e4352ad2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review shaojie-dong-isrc-iscas-ac-cn/staging-rtl8712-check-register_netdev-return-value/20201207-000540
        git checkout a5d44fc70b0f1b3d0a23e3c3bab16a04e4352ad2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/usb/ch9.h:36,
                    from include/linux/usb.h:6,
                    from drivers/staging/rtl8712/hal_init.c:19:
   drivers/staging/rtl8712/hal_init.c: In function 'rtl871x_load_fw_cb':
>> drivers/staging/rtl8712/hal_init.c:49:12: error: 'udev' undeclared (first use in this function); did you mean 'cdev'?
      49 |   dev_err(&udev->dev, "r8712u: register_netdev() failed\n");
         |            ^~~~
   include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
     112 |  _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |           ^~~
   drivers/staging/rtl8712/hal_init.c:49:12: note: each undeclared identifier is reported only once for each function it appears in
      49 |   dev_err(&udev->dev, "r8712u: register_netdev() failed\n");
         |            ^~~~
   include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
     112 |  _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |           ^~~

vim +49 drivers/staging/rtl8712/hal_init.c

    31	
    32	static void rtl871x_load_fw_cb(const struct firmware *firmware, void *context)
    33	{
    34		struct _adapter *adapter = context;
    35	
    36		if (!firmware) {
    37			struct usb_device *udev = adapter->dvobjpriv.pusbdev;
    38			struct usb_interface *usb_intf = adapter->pusb_intf;
    39	
    40			dev_err(&udev->dev, "r8712u: Firmware request failed\n");
    41			usb_put_dev(udev);
    42			usb_set_intfdata(usb_intf, NULL);
    43			complete(&adapter->rtl8712_fw_ready);
    44			return;
    45		}
    46		adapter->fw = firmware;
    47		/* firmware available - start netdev */
    48		if (register_netdev(adapter->pnetdev) != 0)
  > 49			dev_err(&udev->dev, "r8712u: register_netdev() failed\n");
    50		complete(&adapter->rtl8712_fw_ready);
    51	}
    52	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66253 bytes)