linux-kernel - Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40547026-144F-443C-BF14-C7FA0E3229C5@cisco.com>
Date:   Mon, 7 Dec 2020 08:57:00 +0000
From:   "Stefan Schaeckeler (sschaeck)" <sschaeck@...co.com>
To:     Troy Lee <troy_lee@...eedtech.com>,
        Rob Herring <robh+dt@...nel.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        "Borislav Petkov" <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
CC:     "leetroy@...il.com" <leetroy@...il.com>,
        Ryan Chen <ryan_chen@...eedtech.com>,
        Stefan Schaeckeler <schaecsn@....net>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

Hello Troy,

> Hi Stefan,
>
> The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off 
> from u-boot and check if driver runs correctly.

I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my Reviewed-by tag after you addressed Andrew's last comment.



> The test doc you provided is very nice and detailed, I'll try to reproduce the 
> injection test in v2 patch.

It does not harm to redo the testing. That is time-consuming and with your current, now trivial changes, it's not really necessary.

 Stefan