linux-kernel - RE: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PS1PR06MB26008D10C46C5DF0B47F81368AF40@PS1PR06MB2600.apcprd06.prod.outlook.com>
Date:   Tue, 1 Dec 2020 10:04:51 +0000
From:   Troy Lee <troy_lee@...eedtech.com>
To:     "Stefan Schaeckeler (sschaeck)" <sschaeck@...co.com>,
        Rob Herring <robh+dt@...nel.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
CC:     "leetroy@...il.com" <leetroy@...il.com>,
        Ryan Chen <ryan_chen@...eedtech.com>,
        Stefan Schaeckeler <schaecsn@....net>
Subject: RE: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

Hi Stefan,

The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off 
from u-boot and check if driver runs correctly.

The test doc you provided is very nice and detailed, I'll try to reproduce the 
injection test in v2 patch.

Thanks,
Troy Lee

> -----Original Message-----
> From: Stefan Schaeckeler (sschaeck) <sschaeck@...co.com>
> Sent: Monday, November 30, 2020 5:16 PM
> To: Troy Lee <troy_lee@...eedtech.com>; Rob Herring <robh+dt@...nel.org>;
> Joel Stanley <joel@....id.au>; Andrew Jeffery <andrew@...id.au>; Borislav
> Petkov <bp@...en8.de>; Mauro Carvalho Chehab <mchehab@...nel.org>;
> Tony Luck <tony.luck@...el.com>; James Morse <james.morse@....com>;
> Robert Richter <rrichter@...vell.com>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; moderated
> list:ARM/ASPEED MACHINE SUPPORT <linux-arm-kernel@...ts.infradead.org>;
> moderated list:ARM/ASPEED MACHINE SUPPORT
> <linux-aspeed@...ts.ozlabs.org>; open list <linux-kernel@...r.kernel.org>;
> open list:EDAC-CORE <linux-edac@...r.kernel.org>
> Cc: leetroy@...il.com; Ryan Chen <ryan_chen@...eedtech.com>; Stefan
> Schaeckeler <schaecsn@....net>
> Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
> 
> Hello Troy,
> 
> > Adding AST2400 and AST2600 edac driver support.
> >
> > Signed-off-by: Troy Lee <troy_lee@...eedtech.com>
> > ---
> > drivers/edac/Kconfig       |   6 +-
> > drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++--------
> > 2 files changed, 94 insertions(+), 26 deletions(-)
> 
> Uh, there are quite some non-trivial changes. I'll have a look over the coming
> weekend.
> 
> Testing an edac driver comes with challenges. Did you test your code? If so,
> how?
> 
> That's how I was testing my original edac 2500 driver
> http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html
> 
>  Stefan