linux-kernel - Re: [PATCH 2/3] membarrier: Add an actual barrier before rseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201201100604.GT2414@hirez.programming.kicks-ass.net>
Date:   Tue, 1 Dec 2020 11:06:04 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     x86@...nel.org, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Anton Blanchard <anton@...abs.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 2/3] membarrier: Add an actual barrier before
 rseq_preempt()

On Mon, Nov 30, 2020 at 09:50:34AM -0800, Andy Lutomirski wrote:
> It seems to be that most RSEQ membarrier users will expect any
> stores done before the membarrier() syscall to be visible to the
> target task(s).  While this is extremely likely to be true in
> practice, nothing actually guarantees it by a strict reading of the
> x86 manuals.  Rather than providing this guarantee by accident and
> potentially causing a problem down the road, just add an explicit
> barrier.

A very long time ago; when Jens introduced smp_call_function(), we had
this discussion. At the time Linus said that receiving an interrupt had
better be ordering, and if it is not, then it's up to the architecture
to handle that before it gets into the common code.

  https://lkml.kernel.org/r/alpine.LFD.2.00.0902180744520.21686@localhost.localdomain

Maybe we want to revisit this now, but there might be a fair amount of
code relying on all this by now.

Documenting it better might help.

> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> ---
>  kernel/sched/membarrier.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c
> index e23e74d52db5..7d98ef5d3bcd 100644
> --- a/kernel/sched/membarrier.c
> +++ b/kernel/sched/membarrier.c
> @@ -40,6 +40,14 @@ static void ipi_mb(void *info)
>  
>  static void ipi_rseq(void *info)
>  {
> +	/*
> +	 * Ensure that all stores done by the calling thread are visible
> +	 * to the current task before the current task resumes.  We could
> +	 * probably optimize this away on most architectures, but by the
> +	 * time we've already sent an IPI, the cost of the extra smp_mb()
> +	 * is negligible.
> +	 */
> +	smp_mb();
>  	rseq_preempt(current);
>  }

So I think this really isn't right.