linux-kernel - Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7ae5645-9437-2f03-b0c8-35c1812747d2@redhat.com>
Date:   Mon, 7 Dec 2020 11:29:30 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Stefano Garzarella <sgarzare@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, shahafs@...lanox.com
Subject: Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver


On 2020/12/5 上午1:12, Randy Dunlap wrote:
> On 12/4/20 7:20 AM, Stefano Garzarella wrote:
>> On Fri, Dec 04, 2020 at 12:03:53PM +0800, Jason Wang wrote:
>>> This patch introduce a vDPA driver for virtio-pci device. It bridges
>>> the virtio-pci control command to the vDPA bus. This will be used for
>>> features prototyping and testing.
>>>
>>> Note that get/restore virtqueue state is not supported which needs
>>> extension on the virtio specification.
>>>
>>> Signed-off-by: Jason Wang <jasowang@...hat.com>
>>> ---
>>> drivers/vdpa/Kconfig              |   6 +
>>> drivers/vdpa/Makefile             |   1 +
>>> drivers/vdpa/virtio_pci/Makefile  |   2 +
>>> drivers/vdpa/virtio_pci/vp_vdpa.c | 455 ++++++++++++++++++++++++++++++
>>> 4 files changed, 464 insertions(+)
>>> create mode 100644 drivers/vdpa/virtio_pci/Makefile
>>> create mode 100644 drivers/vdpa/virtio_pci/vp_vdpa.c
>>>
>>> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
>>> index 358f6048dd3c..18cad14f533e 100644
>>> --- a/drivers/vdpa/Kconfig
>>> +++ b/drivers/vdpa/Kconfig
>>> @@ -48,4 +48,10 @@ config MLX5_VDPA_NET
>>>        be executed by the hardware. It also supports a variety of stateless
>>>        offloads depending on the actual device used and firmware version.
>>>
>>> +config VP_VDPA
>>> +    tristate "Virtio PCI bridge vDPA driver"
>>> +    depends on PCI_MSI && VIRTIO_PCI_MODERN
>>> +    help
>>> +      This kernel module that bridges virtio PCI device to vDPA bus.
>>                               ^
>> Without 'that' maybe sound better, but I'm not a native speaker :-)
> Yes, drop 'that', please.


Will fix.

Thanks


>
>>> +
>>> endif # VDPA