lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Dec 2020 11:30:23 +0800 From: Chen-Yu Tsai <wens@...nel.org> To: Shawn Lin <shawn.lin@...k-chips.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com> Cc: Heiko Stübner <heiko@...ech.de>, Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Chen-Yu Tsai <wens@...nel.org>, Robin Murphy <robin.murphy@....com>, Johan Jonker <jbx6244@...il.com>, linux-pci@...r.kernel.org, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, devicetree <devicetree@...r.kernel.org> Subject: Re: [PATCH v2 1/4] PCI: rockchip: Make 'ep-gpios' DT property optional Ping On Wed, Nov 18, 2020 at 4:49 PM Heiko Stübner <heiko@...ech.de> wrote: > > Am Mittwoch, 18. November 2020, 08:17:21 CET schrieb Chen-Yu Tsai: > > From: Chen-Yu Tsai <wens@...e.org> > > > > The Rockchip PCIe controller DT binding clearly states that 'ep-gpios' is > > an optional property. And indeed there are boards that don't require it. > > > > Make the driver follow the binding by using devm_gpiod_get_optional() > > instead of devm_gpiod_get(). > > > > Fixes: e77f847df54c ("PCI: rockchip: Add Rockchip PCIe controller support") > > Fixes: 956cd99b35a8 ("PCI: rockchip: Separate common code from RC driver") > > Fixes: 964bac9455be ("PCI: rockchip: Split out rockchip_pcie_parse_dt() to parse DT") > > Signed-off-by: Chen-Yu Tsai <wens@...e.org> > > Reviewed-by: Heiko Stuebner <heiko@...ech.de It's been close to three weeks since this was sent. Any chance we can get this into v5.10 or v5.11? Regards ChenYu > I'll pick up patches 2-4 separately, after giving Rob a chance to look at > the simple binding. > > > Heiko > > > --- > > Changes since v1: > > > > - Rewrite subject to match existing convention and reference > > 'ep-gpios' DT property instead of the 'ep_gpio' field > > --- > > drivers/pci/controller/pcie-rockchip.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > > index 904dec0d3a88..c95950e9004f 100644 > > --- a/drivers/pci/controller/pcie-rockchip.c > > +++ b/drivers/pci/controller/pcie-rockchip.c > > @@ -118,7 +118,7 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) > > } > > > > if (rockchip->is_rc) { > > - rockchip->ep_gpio = devm_gpiod_get(dev, "ep", GPIOD_OUT_HIGH); > > + rockchip->ep_gpio = devm_gpiod_get_optional(dev, "ep", GPIOD_OUT_HIGH); > > if (IS_ERR(rockchip->ep_gpio)) { > > dev_err(dev, "missing ep-gpios property in node\n"); > > return PTR_ERR(rockchip->ep_gpio); > > > > > >
Powered by blists - more mailing lists