linux-kernel - Re: [PATCH] riscv: Fixed kernel test robot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871rg0cajt.fsf@igel.home>
Date:   Tue, 08 Dec 2020 21:22:46 +0100
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, guoren@...ux.alibaba.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: Fixed kernel test robot warning

On Dez 09 2020, Souptick Joarder wrote:

> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@...ux-m68k.org> wrote:
>>
>> On Dez 09 2020, Souptick Joarder wrote:
>>
>> > Kernel test robot throws below warning -
>> >
>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>> > for 'asm_offsets' [-Wmissing-prototypes]
>> >       14 | void asm_offsets(void)
>> >          |      ^~~~~~~~~~~
>> >
>> > This patch should fixed it.
>>
>> Or rename it to main, like most other asm-offsets files.
>
> Few asm-offsets files named it as foo(). Does a rename to main() will
> work straight forward ?

Calling it main will suppress the warning, but other than that it is
completely irrelevant how you call it.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."