linux-kernel - Re: [PATCH] riscv: Fixed kernel test robot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-0e645b05-d32f-42ea-874a-4c91273f5bb6@palmerdabbelt-glaptop1>
Date:   Thu, 10 Dec 2020 17:47:58 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     schwab@...ux-m68k.org
CC:     jrdr.linux@...il.com, Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, guoren@...ux.alibaba.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:     Re: [PATCH] riscv: Fixed kernel test robot warning

On Tue, 08 Dec 2020 12:22:46 PST (-0800), schwab@...ux-m68k.org wrote:
> On Dez 09 2020, Souptick Joarder wrote:
>
>> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@...ux-m68k.org> wrote:
>>>
>>> On Dez 09 2020, Souptick Joarder wrote:
>>>
>>> > Kernel test robot throws below warning -
>>> >
>>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>>> > for 'asm_offsets' [-Wmissing-prototypes]
>>> >       14 | void asm_offsets(void)
>>> >          |      ^~~~~~~~~~~
>>> >
>>> > This patch should fixed it.
>>>
>>> Or rename it to main, like most other asm-offsets files.
>>
>> Few asm-offsets files named it as foo(). Does a rename to main() will
>> work straight forward ?
>
> Calling it main will suppress the warning, but other than that it is
> completely irrelevant how you call it.

Ya, I think it doesn't really matter so I'm just going to take this as is.
It's on for-next (being a bit paranoid, as we're so late in the cycle).