linux-kernel - RE: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY5PR02MB6260399E717A00FFEE32F290BBCD0@BY5PR02MB6260.namprd02.prod.outlook.com>
Date:   Tue, 8 Dec 2020 21:40:44 +0000
From:   Sonal Santan <sonals@...inx.com>
To:     Tom Rix <trix@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        Max Zhen <maxz@...inx.com>, Lizhi Hou <lizhih@...inx.com>,
        Michal Simek <michals@...inx.com>,
        Stefano Stabellini <stefanos@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview

Hello Tom,

> -----Original Message-----
> From: Tom Rix <trix@...hat.com>
> Sent: Sunday, December 6, 2020 8:31 AM
> To: Sonal Santan <sonals@...inx.com>; linux-kernel@...r.kernel.org
> Cc: Sonal Santan <sonals@...inx.com>; linux-fpga@...r.kernel.org; Max Zhen
> <maxz@...inx.com>; Lizhi Hou <lizhih@...inx.com>; Michal Simek
> <michals@...inx.com>; Stefano Stabellini <stefanos@...inx.com>;
> devicetree@...r.kernel.org
> Subject: Re: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview
> 
> On 11/28/20 4:00 PM, Sonal Santan wrote:
> > Hello,
> >
> > This patch series adds management physical function driver for Xilinx
> > Alveo PCIe accelerator cards,
> > https://www.xilinx.com/products/boards-and-kits/alveo.html
> > This driver is part of Xilinx Runtime (XRT) open source stack.
> 
> A few general things.
> 
> Use scripts/get_maintainer.pl to find who a patch should go to, i should have
> been on the cc line.
> 
Will do.
> Each patch should at a minimum pass scripts/checkpatch.pl, none do.
> 
Looks like a few files missed our checkpatch process. Will address in the
upcoming patch series.

> Looking broadly at the files, there are competing names xrt or alveo.
> 
> It seems like xrt is the dfl equivalent, so maybe
> 
> drivers/fpga/alveo should be drivers/fpga/xrt
> 
Agreed. Will address in the next patch series.
> There are a lot of files with unnecessary prefixes
> 
> ex/
> 
> fpga/alveo/include/xrt-ucs.h could just be fpga/alveo/include/ucs.h
> 
Would work on separating xrt infrastructure and subdevs header files
into separate directories and drop the xrt prefix. 
> individual subdev's may not belong in the fpga subsystem.
> 
> I think it would be better to submit these one at a time as is done for dfl.
> 
In the upcoming patch revision, will drop the subdevs except bare minimum 
necessary to perform bitstream download.
> So this will not block getting the basics done, in the next revision, can you leave
> the subdev's out ?
> 
> 
Thanks for the feedback.
-Sonal
> 
> Because of the checkpatch.pl failures, I will wait for the next revision.
> 
> Tom
>