linux-kernel - Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff0d08c891d22ddcd09edb87b82881eeb6cee19f.camel@gmail.com>
Date:   Tue, 08 Dec 2020 22:42:34 +0100
From:   Bean Huo <huobean@...il.com>
To:     Avri Altman <Avri.Altman@....com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>
Subject: Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate
 among CDB, OSF, and TM

On Tue, 2020-12-08 at 08:35 +0000, Avri Altman wrote:
> > didn't differenciate them. we take all of these as CDB. This is
> > wrong.
> > 
> > I want to make it clearer and make UPIU trace in line with the
> > Spec.
> > what's more,  how do you filter OSF, TM parameters with current
> > UPIU
> > trace? you take all of them as CDB? if so, I think, it's better to
> > change parser.
> 
> Indeed, it is just a small change, but breaking user-space is not an
> acceptable approach.
> Also, the upiu tracer was never meant to be human-readable: it just
> dump the upiu,
> Which contains all the info required to parse it anyway,
> So breaking user-space just to making it more readable doesn't really
> make sense?
> 
> Looking at the previous 2 patches of this series, I was hoping that
> you will do the same for
> Command upiu, as well?
> Again - same comment: if you are doing that need to change the str
> not to break current parsers.
> 
> Thanks,
> Avri

will not change original CDB format, just add new OSF, TM.
the string format will not be change. The current the HDR and CDB in
the send and complete trace are the same, I guess, you even didn't
trace CDB in your parser, they cannot tell you the request execution
result.

Bean