linux-kernel - Re: [PATCH 01/12] media: atomsip: Convert comments to C99 initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201208102144.GA2767@kadam>
Date:   Tue, 8 Dec 2020 13:21:44 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Philipp Gerlesberger <Philipp.Gerlesberger@....de>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...cs.fau.de, gregkh@...uxfoundation.org,
        ij72uhux@...d.informatik.uni-erlangen.de,
        sakari.ailus@...ux.intel.com, mchehab@...nel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 01/12] media: atomsip: Convert comments to C99
 initializers

On Mon, Dec 07, 2020 at 08:26:27PM +0100, Philipp Gerlesberger wrote:
> The struct initalizers have been changed as recommended on
> https://kernelnewbies.org/KernelJanitors/Todo
> 
> Co-developed-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> Signed-off-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@....de>
> ---
>  .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c  | 30 +++++++++----------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> index b4f53be18e7f..af61d05e88d3 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> @@ -31,33 +31,33 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];
>   * @brief VBUF resource pool - refpool
>   */
>  static struct ia_css_rmgr_vbuf_pool refpool = {
> -	false,			/* copy_on_write */
> -	false,			/* recycle */
> -	0,			/* size */
> -	0,			/* index */
> -	NULL,			/* handles */
> +	.copy_on_write	= false,
> +	.recycle	= false,
> +	.size		= 0,
> +	.index		= 0,
> +	.handles	= NULL,

If you're using C99 initializers then you can remove all the false, 0
and NULL members.

regards,
dan carpenter