linux-kernel - Re: [PATCH 06/12] media: atomisp: Add parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201208113053.GB2767@kadam>
Date:   Tue, 8 Dec 2020 14:30:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Philipp Gerlesberger <Philipp.Gerlesberger@....de>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...cs.fau.de, gregkh@...uxfoundation.org,
        ij72uhux@...d.informatik.uni-erlangen.de,
        sakari.ailus@...ux.intel.com, mchehab@...nel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 06/12] media: atomisp: Add parentheses

On Mon, Dec 07, 2020 at 08:26:33PM +0100, Philipp Gerlesberger wrote:
> ERROR:COMPLEX_MACRO: Macros with complex values should be
> enclosed in parentheses
> 
> Co-developed-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> Signed-off-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@....de>
> ---
>  .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h    | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> index 9cd3d92b34c9..2c02dd1cf27a 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> @@ -22,8 +22,8 @@
>  #define STORAGE_CLASS_RMGR_H extern
>  #define STORAGE_CLASS_RMGR_C
>  #else				/* __INLINE_RMGR__ */
> -#define STORAGE_CLASS_RMGR_H static inline
> -#define STORAGE_CLASS_RMGR_C static inline
> +#define STORAGE_CLASS_RMGR_H (static inline)
> +#define STORAGE_CLASS_RMGR_C (static inline)

This will break the build.

You should just remove these defines.  They don't make any sort of
sense.  The programmer should know what things need to be static and
what not.  Generally leave "inline" out, and let the compiler decide.
If you have a legit reason to think you are smarter than the compiler
(benchmarking data) then probably __always_inline is more appropriate.

regards,
dan carpenter