linux-kernel - Re: [PATCH v3 0/2] Introduce perf-stat -b for BPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Dec 2020 14:36:23 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Song Liu <songliubraving@...com>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com,
        peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org
Subject: Re: [PATCH v3 0/2] Introduce perf-stat -b for BPF programs

Em Tue, Dec 08, 2020 at 10:16:44AM -0800, Song Liu escreveu:
> This set introduces perf-stat -b option to count events for BPF programs.
> This is similar to bpftool-prog-profile. But perf-stat makes it much more
> flexible.
> 
> Changes v2 => v3:
>   1. Small fixes in Makefile.perf and bpf_counter.c (Jiri)
>   2. Rebased on top of bpf-next. This is because 1/2 conflicts with some
>      patches in bpftool/Makefile.

Can't you split that up so that I can process the perf part and the
bpftool goes via the bpf-next tree?

- Arnaldo
 
> Changes PATCH v1 => PATCH v2:
>   1. Various fixes in Makefiles. (Jiri)
>   2. Fix an build warning/error with gcc-10. (Jiri)
> 
> Changes RFC v2 => PATCH v1:
>   1. Support counting on multiple BPF programs.
>   2. Add BPF handling to target__validate().
>   3. Improve Makefile. (Jiri)
> 
> Changes RFC v1 => RFC v2:
>   1. Use bootstrap version of bpftool. (Jiri)
>   2. Set default to not building bpf skeletons. (Jiri)
>   3. Remove util/bpf_skel/Makefile, keep all the logic in Makefile.perf.
>      (Jiri)
>   4. Remove dependency to vmlinux.h in the two skeletons. The goal here is
>      to enable building perf without building kernel (vmlinux) first.
>      Note: I also removed the logic that build vmlinux.h. We can add that
>      back when we have to use it (to access big kernel structures).
> 
> Song Liu (2):
>   perf: support build BPF skeletons with perf
>   perf-stat: enable counting events for BPF programs
> 
>  tools/bpf/bpftool/Makefile                    |   3 +
>  tools/build/Makefile.feature                  |   4 +-
>  tools/perf/Makefile.config                    |   9 +
>  tools/perf/Makefile.perf                      |  48 ++-
>  tools/perf/builtin-stat.c                     |  77 ++++-
>  tools/perf/util/Build                         |   1 +
>  tools/perf/util/bpf_counter.c                 | 297 ++++++++++++++++++
>  tools/perf/util/bpf_counter.h                 |  73 +++++
>  tools/perf/util/bpf_skel/.gitignore           |   3 +
>  .../util/bpf_skel/bpf_prog_profiler.bpf.c     |  93 ++++++
>  tools/perf/util/evsel.c                       |  11 +
>  tools/perf/util/evsel.h                       |   6 +
>  tools/perf/util/stat-display.c                |   4 +-
>  tools/perf/util/target.c                      |  34 +-
>  tools/perf/util/target.h                      |  10 +
>  tools/scripts/Makefile.include                |   1 +
>  16 files changed, 655 insertions(+), 19 deletions(-)
>  create mode 100644 tools/perf/util/bpf_counter.c
>  create mode 100644 tools/perf/util/bpf_counter.h
>  create mode 100644 tools/perf/util/bpf_skel/.gitignore
>  create mode 100644 tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> 
> --
> 2.24.1

-- 

- Arnaldo