linux-kernel - Re: [PATCH v3 1/2] perf: support build BPF skeletons with perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1F517361-8651-4EA5-ADBD-B8368E969C5B@fb.com>
Date:   Wed, 9 Dec 2020 23:32:07 +0000
From:   Song Liu <songliubraving@...com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     lkml <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [PATCH v3 1/2] perf: support build BPF skeletons with perf



> On Dec 9, 2020, at 9:03 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> 
> On Tue, Dec 08, 2020 at 10:16:45AM -0800, Song Liu wrote:
>> BPF programs are useful in perf to profile BPF programs. BPF skeleton is
>> by far the easiest way to write BPF tools. Enable building BPF skeletons
>> in util/bpf_skel. A dummy bpf skeleton is added. More bpf skeletons will
>> be added for different use cases.
>> 
>> Signed-off-by: Song Liu <songliubraving@...com>
> 
> one nit below, but other than that:
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks!

[...]

>> 
>> +ifdef BUILD_BPF_SKEL
>> +  $(call feature_check,clang-bpf-co-re)
>> +  ifeq ($(feature-clang-bpf-co-re), 0)
>> +    dummy := $(error Error: clang too old. Please install recent clang)
>> +  endif
>> +  $(call detected,CONFIG_PERF_BPF_SKEL)
>> +  CFLAGS += -DBUILD_BPF_SKEL
> 
> sorry I did not notice before, but we use HAVE_* name style for these C macros 
> 
> HAVE_BPF_SKEL should fit

I will fix this in v4.