lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2020 15:28:48 +0800 From: David Gow <davidgow@...gle.com> To: Daniel Latypov <dlatypov@...gle.com> Cc: Brendan Higgins <brendanhiggins@...gle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH] kunit: tool: simplify kconfig is_subset_of() logic On Wed, Dec 9, 2020 at 7:21 AM Daniel Latypov <dlatypov@...gle.com> wrote: > > Don't use an O(nm) algorithm* and make it more readable by using a dict. > > *Most obviously, it does a nested for-loop over the entire other config. > A bit more subtle, it calls .entries(), which constructs a set from the > list for _every_ outer iteration. > > Signed-off-by: Daniel Latypov <dlatypov@...gle.com> > --- Thanks! This works great here: I didn't time it to see how much faster it is, but it's clearly an improvement. Reviewed-by: David Gow <davidgow@...gle.com> Cheers, -- David
Powered by blists - more mailing lists