[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAFd5g456hj7D_xQkYQZbSD4yhKxaJNY0iF1LjjkzLYgiB8avAA@mail.gmail.com>
Date: Fri, 5 Feb 2021 14:28:16 -0800
From: Brendan Higgins <brendanhiggins@...gle.com>
To: Daniel Latypov <dlatypov@...gle.com>
Cc: David Gow <davidgow@...gle.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: tool: simplify kconfig is_subset_of() logic
On Tue, Dec 8, 2020 at 3:21 PM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> Don't use an O(nm) algorithm* and make it more readable by using a dict.
>
> *Most obviously, it does a nested for-loop over the entire other config.
> A bit more subtle, it calls .entries(), which constructs a set from the
> list for _every_ outer iteration.
>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
Tested-by: Brendan Higgins <brendanhiggins@...gle.com>
Acked-by: Brendan Higgins <brendanhiggins@...gle.com>
Powered by blists - more mailing lists