linux-kernel - Re: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210061844.GA21126@infradead.org>
Date:   Thu, 10 Dec 2020 06:18:44 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        Ley Foon Tan <ley.foon.tan@...el.com>,
        Mark Salter <msalter@...hat.com>,
        Aurelien Jacquiot <jacquiot.aurelien@...il.com>,
        linux-c6x-dev@...ux-c6x.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] block: blk-iocost: fix build for ARCH with missing
 local64.h files

On Wed, Dec 09, 2020 at 10:16:20PM -0800, Randy Dunlap wrote:
> include/asm-generic/local64.h has comments about some $arch could do
> its things better/faster instead of using asm-generic, but no $arch has
> done that since 2010 when it was added.
> 
> Is that conclusive?
> If it is, why even use mandatory-y?
> Why not just change all occurrences of <asm/local64.h>
> to <asm-generic/local64.h> ?

asm-generic must not be included by non-arch code directly.  So the
sensible options are either:

 a) mark it as mandatory-y in include/asm-generic/Kbuild
 b) rename it to linux/local64.h and fixup all references

a) seems much less invasive, but b) might be the better option long
term.