linux-kernel - Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210092535.GB322060@ubuntu2004>
Date:   Thu, 10 Dec 2020 11:25:35 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@...il.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Andreas Färber <afaerber@...e.de>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common
 property

Hi Mani,

On Thu, Dec 10, 2020 at 09:36:44AM +0530, Manivannan Sadhasivam wrote:
> On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:
> > Add a new common property 'reset-time-sec' to be used in conjunction
> > with the devices supporting the key pressed reset feature.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> > ---
> > Changes in v3:
> >  - This patch was not present in v2
> > 
> >  Documentation/devicetree/bindings/input/input.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> > index ab407f266bef..caba93209ae7 100644
> > --- a/Documentation/devicetree/bindings/input/input.yaml
> > +++ b/Documentation/devicetree/bindings/input/input.yaml
> > @@ -34,4 +34,11 @@ properties:
> >        specify this property.
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >  
> > +  reset-time-sec:
> > +    description:
> > +      Duration in seconds which the key should be kept pressed for device to
> > +      reset automatically. Device with key pressed reset feature can specify
> > +      this property.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> 
> Why can't you just use "power-off-time-sec"?

I think the common behavior of keeping the power button pressed is to
trigger a power off rather than a reset. Hence, per Rob's suggestion in
the previous revision of this patch series, I added the reset variant:
https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/

Thanks,
Cristi

> Thanks,
> Mani
> 
> >  additionalProperties: true
> > -- 
> > 2.29.2
> >