linux-kernel - Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211031642.GA3556770@robh.at.kernel.org>
Date:   Thu, 10 Dec 2020 21:16:42 -0600
From:   Rob Herring <robh@...nel.org>
To:     Cristian Ciocaltea <cristian.ciocaltea@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Andreas Färber <afaerber@...e.de>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common
 property

On Thu, Dec 10, 2020 at 11:13:50AM +0200, Cristian Ciocaltea wrote:
> Hi Rob,
> 
> On Wed, Dec 09, 2020 at 09:37:08PM -0600, Rob Herring wrote:
> > On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:
> > > Add a new common property 'reset-time-sec' to be used in conjunction
> > > with the devices supporting the key pressed reset feature.
> > > 
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> > > ---
> > > Changes in v3:
> > >  - This patch was not present in v2
> > > 
> > >  Documentation/devicetree/bindings/input/input.yaml | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> > > index ab407f266bef..caba93209ae7 100644
> > > --- a/Documentation/devicetree/bindings/input/input.yaml
> > > +++ b/Documentation/devicetree/bindings/input/input.yaml
> > > @@ -34,4 +34,11 @@ properties:
> > >        specify this property.
> > >      $ref: /schemas/types.yaml#/definitions/uint32
> > >  
> > > +  reset-time-sec:
> > 
> > Humm, I'm pretty sure we already have something for this. Or maybe just 
> > power off.
> 
> We only have 'power-off-time-sec', so I added 'reset-time-sec' according
> to your review in v2:
> https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/

I'm doing good if I remember reviews from a week ago. From 3 months ago, 
no chance without some reminder.

Reviewed-by: Rob Herring <robh@...nel.org>

Rob