linux-kernel - Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <724285f7c2d2544a11adfedf89aad1f9e8c684ca.camel@kernelconcepts.de>
Date:   Thu, 10 Dec 2020 13:29:46 +0100
From:   Simon Budig <simon.budig@...nelconcepts.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     Marco Felsch <m.felsch@...gutronix.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of
 electrodes

On Wed, 2020-12-09 at 15:09 -0800, Dmitry Torokhov wrote:
> Instead of using special-casing retrieval of number of X/Y electrodes
> based on the firmware, let's select default values and mark registers
> as
> non-existent on firmwares that do not support this operation.
> 
> Also mark "report rate" register as non-existent for generic
> firmwares as
> having it set to 0 does not make sense.

Looks good.

Reviewed-by: Simon Budig <simon.budig@...nelconcepts.de>

Thanks,
        Simon
-- 
     kernel concepts GmbH                 Simon Budig
     Hauptstraße 16                       simon.budig@...nelconcepts.de
     D-57076 Siegen                       +49-271-771091-17
     http://www.kernelconcepts.de/
     HR Siegen, HR B 9613; Geschäftsführer: Ole Reinhardt

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)