linux-kernel - Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

Open Source and information security mailing list archives

Message-ID: <87zh2k7jr6.fsf@intel.com>
Date:   Fri, 11 Dec 2020 11:51:57 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Mark Rutland <mark.rutland@....com>,
        Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>,
        Peter Zijlstra <peterz@...radead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        dri-devel@...ts.freedesktop.org,
        Chris Wilson <chris@...is-wilson.co.uk>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Russell King <linux@...linux.org.uk>,
        afzal mohammed <afzal.mohd.ma@...il.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Rob Herring <robh@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Dave Jiang <dave.jiang@...el.com>,
        Leon Romanovsky <leon@...nel.org>, linux-rdma@...r.kernel.org,
        Marc Zyngier <maz@...nel.org>, Helge Deller <deller@....de>,
        Michal Simek <michal.simek@...inx.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-pci@...r.kernel.org, xen-devel@...ts.xenproject.org,
        intel-gfx@...ts.freedesktop.org,
        Wambui Karuga <wambui.karugax@...il.com>,
        Allen Hubbe <allenbh@...il.com>, Will Deacon <will@...nel.org>,
        linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        linux-gpio@...r.kernel.org,
        Stefano Stabellini <sstabellini@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        Juergen Gross <jgross@...e.com>,
        David Airlie <airlied@...ux.ie>, linux-parisc@...r.kernel.org,
        netdev@...r.kernel.org, Hou Zhiqiang <Zhiqiang.Hou@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>, Jon Mason <jdmason@...zu.us>,
        linux-ntb@...glegroups.com, Saeed Mahameed <saeedm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

On Thu, 10 Dec 2020, Ville Syrjälä <ville.syrjala@...ux.intel.com> wrote:
> On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote:
>> Nothing uses the result and nothing should ever use it in driver code.
>> 
>> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Daniel Vetter <daniel@...ll.ch>
>> Cc: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>
>> Cc: Chris Wilson <chris@...is-wilson.co.uk>
>> Cc: Wambui Karuga <wambui.karugax@...il.com>
>> Cc: intel-gfx@...ts.freedesktop.org
>> Cc: dri-devel@...ts.freedesktop.org
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>

Thomas, I presume you want to merge this series as a whole.

Acked-by: Jani Nikula <jani.nikula@...el.com>

for merging via whichever tree makes most sense. Please let us know if
you want us to pick this up via drm-intel instead.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_lpe_audio.c |    4 ----
>>  1 file changed, 4 deletions(-)
>> 
>> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> @@ -297,13 +297,9 @@ int intel_lpe_audio_init(struct drm_i915
>>   */
>>  void intel_lpe_audio_teardown(struct drm_i915_private *dev_priv)
>>  {
>> -	struct irq_desc *desc;
>> -
>>  	if (!HAS_LPE_AUDIO(dev_priv))
>>  		return;
>>  
>> -	desc = irq_to_desc(dev_priv->lpe_audio.irq);
>> -
>>  	lpe_audio_platdev_destroy(dev_priv);
>>  
>>  	irq_free_desc(dev_priv->lpe_audio.irq);
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives