linux-kernel - Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 10:53:05 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        nsaenzjulienne@...e.de, f.fainelli@...il.com, rjui@...adcom.com,
        sean@...s.org, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pwm@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic
 configuration

On Fri, Dec 11, 2020 at 10:28:35AM +0100, Lino Sanfilippo wrote:
> Hi Uwe,
> 
> > Gesendet: Donnerstag, 10. Dezember 2020 um 12:43 Uhr
> > Von: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> > An: "Lino Sanfilippo" <LinoSanfilippo@....de>
> > Cc: thierry.reding@...il.com, lee.jones@...aro.org, nsaenzjulienne@...e.de, f.fainelli@...il.com, rjui@...adcom.com, sean@...s.org, sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com, linux-pwm@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
> > Betreff: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration
> 
> > 
> > Side note: I'm a bit surprised about the output of
> > 
> > 	b4 diff 1607464905-16630-1-git-send-email-LinoSanfilippo@....de
> > 
> > This is probably due to the fact that compared to v3 you also rebased.
> > Still the diff is quite big.
> 
> You are right, I made a rebase before I created the last patch, sorry for the confusion this caused.
> Anyway, thanks for the review(s)!

You did everything good enough. (To further improve, you could use
git-format-patch's --base option and mention a rebase in the series'
changelog; note this is quite high level critic.)

This was more me wondering the output is not easier to use. (And note I
also showed the wrong commandline, but that doesn't resolve the issue.
The right command is:

	b4 diff 1607546905-20549-1-git-send-email-LinoSanfilippo@....de

.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)