linux-kernel - Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 13:10:49 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

Why does your mailer thread emails?

Your reply is not detached from the remainder of the thread.

On Fri, 11 Dec 2020, David Laight wrote:
> From: Lee Jones
> > Sent: 11 December 2020 10:06
> > 
> > On Fri, 11 Dec 2020, Zheng Yongjun wrote:
> > 
> > > Replace a comma between expression statements by a semicolon.
> > >
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> > > ---
> > >  drivers/mfd/rave-sp.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> > > index 545196c85b5c..abb9cbdabaa9 100644
> > > --- a/drivers/mfd/rave-sp.c
> > > +++ b/drivers/mfd/rave-sp.c
> > > @@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
> > >
> > >  	ackid       = atomic_inc_return(&sp->ackid);
> > >  	reply.ackid = ackid;
> > > -	reply.code  = rave_sp_reply_code((u8)command),
> > > +	reply.code  = rave_sp_reply_code((u8)command);
> > 
> > How did the original code not create a build error?
> 
> Nowt wrong with commas.

Well you learn something new every day!

> Why not go the other way.
> Convert almost all the ; to , and delete most of the { } in
> if and for statements (etc).

Sorry, I don't understand.  Please elaborate/provide an example.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog