linux-kernel - RE: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10351cc41c244d9a8cfa6a8fb8f502c3@AcuMS.aculab.com>
Date:   Fri, 11 Dec 2020 13:15:38 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Lee Jones' <lee.jones@...aro.org>
CC:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

From: Lee Jones
> Sent: 11 December 2020 13:11
...
> > Nowt wrong with commas.
> 
> Well you learn something new every day!
> 
> > Why not go the other way.
> > Convert almost all the ; to , and delete most of the { } in
> > if and for statements (etc).
> 
> Sorry, I don't understand.  Please elaborate/provide an example.

You can (largely) replace:
	if (...) {
		xxx;
		yyy;
	}
	zzz;
With
	if (...)
		xxx,
		yyy;
	zzz;

Saves a vertical line....
You may need to replace some 'if' by ?: to avoid the terminating ;

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)