linux-kernel - Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201211144553.GF5029@dell>
Date:   Fri, 11 Dec 2020 14:45:53 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon

On Fri, 11 Dec 2020, David Laight wrote:

> From: Lee Jones
> > Sent: 11 December 2020 13:11
> ...
> > > Nowt wrong with commas.
> > 
> > Well you learn something new every day!
> > 
> > > Why not go the other way.
> > > Convert almost all the ; to , and delete most of the { } in
> > > if and for statements (etc).
> > 
> > Sorry, I don't understand.  Please elaborate/provide an example.
> 
> You can (largely) replace:
> 	if (...) {
> 		xxx;
> 		yyy;
> 	}
> 	zzz;
> With
> 	if (...)
> 		xxx,
> 		yyy;
> 	zzz;
> 
> Saves a vertical line....
> You may need to replace some 'if' by ?: to avoid the terminating ;

No, please don't do any of that.

The current patch is fine.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog