linux-kernel - Re: [PATCH] Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211140137.taqjndaqjjo25srj@liuwe-devbox-debian-v2>
Date:   Fri, 11 Dec 2020 14:01:37 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     "Andrea Parri (Microsoft)" <parri.andrea@...il.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org,
        "K . Y . Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] Revert "scsi: storvsc: Validate length of incoming
 packet in storvsc_on_channel_callback()"

On Fri, Dec 11, 2020 at 02:14:04PM +0100, Andrea Parri (Microsoft) wrote:
> This reverts commit 3b8c72d076c42bf27284cda7b2b2b522810686f8.
> 
> Dexuan reported a regression where StorVSC fails to probe a device (and
> where, consequently, the VM may fail to boot).  The root-cause analysis
> led to a long-standing race condition that is exposed by the validation
> /commit in question.  Let's put the new validation aside until a proper
> solution for that race condition is in place.
> 
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> Cc: Dexuan Cui <decui@...rosoft.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: linux-scsi@...r.kernel.org

Hi Martin

Sorry for the last minute patch. We would very like this goes into 5.10
if possible; otherwise Linux 5.10 is going to be broken on Hyper-V.  :-(

Wei.