linux-kernel - Re: [PATCH v2 1/2] dt-bindings: regulator: add pf8x00 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211140412.GD4929@sirena.org.uk>
Date:   Fri, 11 Dec 2020 14:04:13 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Adrien Grassein <adrien.grassein@...il.com>
Cc:     lgirdwood@...il.com, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        troy.kisky@...ndarydevices.com, gary.bisson@...ndarydevices.com
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add pf8x00 PMIC

On Thu, Dec 10, 2020 at 11:16:28PM +0100, Adrien Grassein wrote:
> Add a devicetree binding documentation for the pf8x00 regulator driver.

Please don't send new patches in reply to old threads, it makes it hard
to keep track of what is going on.

> +          regulator-name:
> +            pattern: "^ldo[1-4]$"
> +            description:
> +              should be ldo1", ..., "ldo4"

This is part of the generic regulator binding and since it's for board
specific usage it should not be constrained by the chip binding.

> +          nxp,vselect-en:
> +            $ref: /schemas/types.yaml#definitions/flag
> +            description:
> +              Only available for ldo2. When specified, use the VSELECT
> +              input pin of the chip to control the output voltage of the
> +              ldo02 regulator. (3.3V if VSELECT is LOW, 1.8V if HIGH).

How is VSELECT used without a binding specifying some mechanism for
control?

> +          nxp,ilim-microamp:
> +            $ref: /schemas/types.yaml#definitions/uint32
> +            minimum: 2100
> +            maximum: 4500
> +            default: 2100
> +            enum: [ 2100, 2600, 3000, 4500 ]
> +            description:
> +              Defines the maximum current delivered by the regulator in microamp.

Instead of implementing a custom property this should use the already
existing properties for current limits, this is a common thing for
hardware to have so we shouldn't have custom bindings.  We'll need to
relax the check the code currently has for a non-zero minimum limit but
otherwise everything should already be there.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)